Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get unique hosts from scheduling decision #346

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Aug 3, 2023

This methods are very useful in #345, but we commit them in a separate PR here.

@csegarragonz csegarragonz self-assigned this Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #346 (17ca7de) into main (f3fab63) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   82.16%   82.41%   +0.25%     
==========================================
  Files         102      103       +1     
  Lines        8146     8149       +3     
==========================================
+ Hits         6693     6716      +23     
+ Misses       1453     1433      -20     
Files Changed Coverage Δ
...clude/faabric/batch-scheduler/SchedulingDecision.h 100.00% <100.00%> (ø)
src/batch-scheduler/SchedulingDecision.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@csegarragonz csegarragonz merged commit ccf99e8 into main Aug 4, 2023
13 checks passed
@csegarragonz csegarragonz deleted the decision-unique branch August 4, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant